[PATCH] high CPU load in kded when kdirwatcher falls back to polling

Till Adam adam at kde.org
Sun May 25 13:09:11 BST 2008


on my current OSX Leopard build KDirWatcher seems to want to not use fam, 
although it was found at compile time and thus falls back to polling. 
Unfortunately it doesn't unhook the socket notifier, which keeps firing, for 
some reason, resulting in constant event handler -> singleShotTimer -> noop 
cleanup slot cycles, which burn a lot of CPU. The attached patch attempts to 
address this by making sure the socket notifier is deleted in all cases that 
disable fam. I lack the deeper insight into the code to judge whether there's 
more to it, but it solves the immediate problem for me. Kindly review.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdirwatch-no-fam-fallback-cpu-eater-fix.diff
Type: text/x-patch
Size: 544 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080525/d77d5499/attachment.bin>

More information about the kde-core-devel mailing list