Emoticonslib moved to kdereview

Thiago Macieira thiago at kde.org
Mon May 19 07:28:25 BST 2008

Carlo wrote:
>> * KEmoticonProvider still expose way to much internal stuff   (it
>> returns pointer to QHash: bad)  making it impossible to eventualy
>> change the matching algoritms later.
>*emoticonsMap() is protected so I can modify the qhash inside each
> plugins

Make it a protected getter and a setter then. Don't expose the internals 
unless you have to.

  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080519/c7561944/attachment.sig>

More information about the kde-core-devel mailing list