JuK feature/bugfix; thoughts?

Michael Pyne mpyne at purinchu.net
Tue May 13 03:52:23 BST 2008


Hi all,

I just wanted to ask if it was possible to get a review of a patch to JuK to 
load cover art from an .mp3 file if present, or a image file in the same 
directory.

JuK can already load cover art (which is currently managed by a database-type 
scheme); the patch in question would expand the sources of displayed cover art 
to include the actual .mp3 file and specially named image files in the same 
directory.  It would not allow for writing to the aforementioned image file or 
.mp3 file; all changes to cover art would be made in the database.

The patch is attachment 2 to bug 103118 ( 
http://bugs.kde.org/show_bug.cgi?id=103118 ).  It is also attached.

Reason I'm asking is because we're in feature freeze now (I always pick the 
best times to come back in port :) and I don't want to simply try and stretch 
the definition of "bugfix" that far.

The patch itself is relatively non-intrusive and read-only (although testing 
is always appreciated).  Is this OK, or should I wait for trunk to be open for 
KDE 4.2?

Regards,
 - Michael Pyne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080512/68576fc3/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cover-art.patch
Type: text/x-patch
Size: 9301 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080512/68576fc3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080512/68576fc3/attachment.sig>


More information about the kde-core-devel mailing list