KIO fixes in kdelibs and kdebase

Vlad vladc6 at yahoo.com
Wed May 7 02:35:27 BST 2008


Hi,

I'd like to commit the attached KIO fixes to kdelibs and kdebase.
Following are descriptions of the patches:

file_fix_open_flags.diff:
- Fix translation of the mode from QIODevice to POSIX flag.

smb_fixes.diff:
- Don't rely on errno because its value changes after the first read.
Instead, save its value in a new variable.
- Ensure passed parameters and return values to samba functions match
their prototype in libsmbclient.h .
- Fix file open flags in FileJob functions
- Implement SMBSlave::write

sftp_fix_open_flags.diff:
- Fix translation of the mode from QIODevice to POSIX flag.

respect_copyjob_permissions.diff:
- Fix KIO::file_move to respect its permissions parameter instead of
just ignoring it. KIO::file_copy already respects the user-specified
permissions.

kdelibs_largefile.diff:
- Compile kdelibs with -D_LARGE_FILES instead of
-D_LARGEFILE64_SOURCE, and drop the redundant -D_LARGEFILE64_SOURCE
flag in kio.

kdebase_largefile.diff:
- Compile kdebase with -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE to
support large files.

Please let me know if there are any objections to my committing these
fixes.

Thanks,
Vlad


      ____________________________________________________________________________________
Be a better friend, newshound, and 
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: file_fix_open_flags.diff
Type: text/x-patch
Size: 1666 bytes
Desc: 3106349870-file_fix_open_flags.diff
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080506/c50562f3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebase_largefile.diff
Type: text/x-patch
Size: 396 bytes
Desc: 2252635123-kdebase_largefile.diff
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080506/c50562f3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs_largefile.diff
Type: text/x-patch
Size: 974 bytes
Desc: 706246257-kdelibs_largefile.diff
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080506/c50562f3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: respect_copyjob_permissions.diff
Type: text/x-patch
Size: 1931 bytes
Desc: 2315708230-respect_copyjob_permissions.diff
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080506/c50562f3/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sftp_fix_open_flags.diff
Type: text/x-patch
Size: 5016 bytes
Desc: 1215049261-sftp_fix_open_flags.diff
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080506/c50562f3/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smb_fixes.diff
Type: text/x-patch
Size: 22506 bytes
Desc: 2767726281-smb_fixes.diff
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080506/c50562f3/attachment-0005.bin>


More information about the kde-core-devel mailing list