Goya in kdereview

[Allen Winter]

On Monday 05 May 2008 18:17:34 Kevin Ottens wrote:
> Hello,
>
> I just moved Goya to kdereview. This effort was started by Rafael, but
> since I wasn't happy with the API I spent quite some time tinkering it and
> it's now ready for inclusion into kdeui IMO.
>
> It now has only one abstract abstract class named KWidgetItemDelegate
> allowing to create delegates embedding widgets for user interaction. You
> only need to implement two pure virtuals and the paint method to be done.
>
> It comes with no issue spotted by krazy, with APIDOX and a small example
> application. I focused on keeping the API as small as possible for future
> migration path (depending on what Qt 4.5 or 4.6 might deliver, I discussed
> about that with Andreas back in FISL).
>
> Let the reviews begin, we're targetting inclusion for 4.1 (it'd make the
> life easier for a few consumers like the job viewer and get hot new stuff
> ui).

The APIDOX is very good, I only found the following small issues.
Also, please add a Mainpage.dox

1. Check for undocumented methods...  OOPS! 8 issues found!
        kwidgetitemdelegate.h: 117, 138 (2)
        kwidgetitemdelegatepool.cpp: 44, 46,47, 49, 50, 51 (6)

2. Check for undocumented parameters...  OOPS! 1 issues found!
        kwidgetitemdelegate.h: 128 (1)

3. Check for unknown parameters...  OOPS! 1 issues found!
        kwidgetitemdelegate.h: 117 (1)

4. Check for methods that are undeclared or undefined...  OOPS! 9 issues 
found!
        kwidgetitemdelegate.cpp: 62, 70, 154, 167, 176, 225, 260 (7)
        kwidgetitemdelegatepool.cpp: 60, 70 (2)

7. Check for mismatched class members...  OOPS! 2 issues found!
        kwidgetitemdelegate.cpp: 58 (1)
        kwidgetitemdelegatepool.cpp: 56 (1)