Glimpse in kdereview

[Aaron J. Seigo]

On Sunday 30 March 2008, Kåre Särs wrote:
> bool makeQImage(const QByteArray &data,
>                 int width, int height,
>                 int bytes_per_line,
>                 ImageFormat format,
>                 QImage &img);

cool. 

suggestion: return a QImage instead of taking one by reference, and set it to 
QImage() on failure. the return can easily check for img.isNull() .. makes 
for a slightly more natural feeling API?

anyways.. would be great to see just one new lib going in rather than two, 
though i really hate discarding people's work =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080330/f5fcec1d/attachment.sig>