[Patch] let KSaveFile honor the umask

Thiago Macieira thiago at kde.org
Thu Mar 27 20:03:28 GMT 2008


Thorsten Zachmann wrote:
>how about using a mutex that will also catch the case where the umask is
>changed while the program is running?

I prefer your earlier idea (getting the umask at program start). Reasons 
why:

1) mutexes are expensive
2) you protect only KTemporaryFile, but *ALL* other file creations in 
other threads (QFile, creat(2), open(2), QTemporaryFile, Unix sockets) go 
unchecked
3) it's highly unlikely that anyone changes the umask during the program 
execution anyways. (but they do create files)

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080327/a320fd77/attachment.sig>


More information about the kde-core-devel mailing list