[PATCH] KFilePlacesModel : separate storage for custom items and standard items

Kevin Ottens ervin at kde.org
Thu Mar 27 10:22:48 GMT 2008

Le Thursday 27 March 2008, nf2 a écrit :
> That's intentional. They have to be a 1:1copy (otherwise my comparator
> won't work and we might run into an endless synchronization ping pong).
> According to the xbel spec it's perfectly ok to have such private
> metadata (that's the whole point of the owner= attribute):

Hmmm, then I forgot to test something, adding something in the shortcuts.xbel 
file directly and see how the synchronization cope with that (it won't have 
an ID for a start).

> But of course only the custom items (not isSystemItem=true) should be
> synchronized (no home, /, remote:, trash: should appear in the
> shortcuts.xbel).

Right, my mistake, I really had more "ID" in mind.

> > Testing your patch I noticed that now the default places have wrong
> > icons... Actually after reverting I still see this behavior, so I wonder
> > if it could be related to your previous changes to KBookmark.
> Could be. I got some migration code for the icons, but who knows. Here
> it works, but of course i have deleted the bookmark files, so
> KFilePlacesModel re-created the default places.

Well, that's what I did, I started over with a clean kfileplaces to let it 

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080327/2bc0b27f/attachment.sig>

More information about the kde-core-devel mailing list