Alien widgets and flickering

[Louai Al-Khanji]

On Wed, Mar 19, 2008 at 8:34 AM, Louai Al-Khanji <louai.khanji at gmail.com> wrote:
> On Tuesday 18 March 2008 19:57:40 Robert Knight wrote:
>  > Hi,
>  >
>  > > Does anyone object to this patch to systemsettings then?
>  >
>  > Please try to make sure there are no unnecessary calls to
>  > QWidget::winId() first.  Apart from the screensaver module which you
>  > mentioned, I cannot see why other modules need it.
>  >
>  > > and I assume it won't be simple for kwin or style
>  > > kcm's either.
>  >
>  > I'm not sure why that would be the case.  What does the style KCM need
>  > a winId for?
>  >
>
>  I just noticed gmail didn't send my reply to David to the list. Basically,
>  probably all other kcm's can be fixed, but not the screensaver previews. The
>  whole screensaver infrastructure under X currently works based on reparenting
>  X windows.
>

I just committed this, along with an explanatory comment.

>
>
>  > Regards,
>  > Robert.
>  >
>  > On 18/03/2008, David Faure <faure at kde.org> wrote:
>  > > On Monday 17 March 2008, Louai Al-Khanji wrote:
>  > >  > On Mon, Mar 17, 2008 at 10:51 PM, Alexander Neundorf <neundorf at kde.org>
>  wrote:
>  > >  > > On Monday 17 March 2008, Louai Al-Khanji wrote:
>  > >  > >  > Hi all,
>  > >  > >
>  > >  > >  ...
>  > >  > >
>  > >  > > > The other solution is to throw away the advantages of alien
>  > >  > > > widgets and
>  > >  > > >
>  > >  > >  > disable them in applications where native widgets are used.
>  > >  > >
>  > >  > >  I have no idea how many applications this are, but if it's only a
>  > >  > > few, then this seems like the obvious solution to me.
>  > >  > >
>  > >  > >  Alex
>  > >  >
>  > >  > There aren't very many, and I think this is the obviously right choice
>  > >  > as well. Does anyone object to this patch to systemsettings then? If
>  > >  > not, I will apply it in a few days.
>  > >
>  > > But the real question IMHO is: why is the winId needed by systemsettings?
>  > >
>  > >  I'm not against the patch, but it should be fully justified, like
>  > > "systemsettings needs native widgets because <xyz>".
>  > >
>  > >
>  > >  --
>  > >  David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
>  > >  Konqueror (http://www.konqueror.org), and KOffice
>  > > (http://www.koffice.org).
>
>
>