[PATCH] KActionCollection: Deprecate actionHighlighted() and rename it actionHovered()

[Nicolas Ternisien]

Hi,

Here is the patch with the requested modification.

Regards.

On Thu, Mar 13, 2008 at 10:24 AM, Nicolas Ternisien
<nicolas.ternisien at gmail.com> wrote:
> Ok, you're right. No problem with this modification
>
>
>
>  On Thu, Mar 13, 2008 at 12:00 AM, Olivier Goffart <ogoffart at kde.org> wrote:
>  > Le mercredi 12 mars 2008, Olivier Goffart a écrit :
>  >
>  >
>  > > Le lundi 10 mars 2008, Nicolas Ternisien a écrit :
>  >  > > Hi,
>  >  > >
>  >  > > I've just done a little patch on KActionCollection, which deprecate
>  >  > > actionHighlighted() and rename it actionHovered(), to match the
>  >  > > QAction API. This patch is linked to my previous and never answered
>  >  > > email attached here.
>  >  > >
>  >  > > That's my first KDEcore patch, so be cool with it ;-)
>  >  >
>  >  > The patch looks almost fine to me.
>  >  > I would say that slotActionHovered() should be private and not virtual.
>  >  > There is no point of having this in the public API.
>  >  ... and you cannot add virtual member anyway or it will break binary
>  >  compatibility
>  >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kactioncollection-signal-hovered-renamed.patch
Type: text/x-diff
Size: 3105 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080317/2107d56a/attachment.patch>