'lightweight' QDir::isAbsolutePath replacement ?

Thiago Macieira thiago at kde.org
Fri Mar 14 10:22:28 GMT 2008


On Friday 14 March 2008 10:54:13 Thiago Macieira wrote:
> On Friday 14 March 2008 10:35:12 Ralf Habacker wrote:
> > Thiago Macieira schrieb:
> > > Ralf Habacker wrote:
> > >>> Here's the patch it will appear in tonight's snapshot. It can't be as
> > >>> fast as Ralf's original code because there's at least one file engine
> > >>> that is queried first (the resource file engine).
> > >>
> > >> Thanks for your efforts.
> > >
> > > Patch reverted because it broke all our Windows builds.
> > >
> > > I do not have more time to dedicate for this before 4.4.0 final.
> >
> > I would take some time to make it complete but how to validate the patch
> > when the test app is not public available ?
>
> You can start by cleaning up your build and recompiling qmake and src/tools
> (moc, uic, rcc). That's where it broke.

I have not found a testcase for isAbsolute, but it's easy to check whether 
we're not breaking behaviour compatibility:

test a few real paths (relative and absolute)
test a few searchdir paths, with existing and non-existing files
test a few resource paths (those starting with :/)

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080314/e7ba2857/attachment.sig>


More information about the kde-core-devel mailing list