'lightweight' QDir::isAbsolutePath replacement ?

[Thiago Macieira]

On Tuesday 11 March 2008 10:52:14 David Faure wrote:
> On Saturday 08 March 2008, Thiago Macieira wrote:
> > David Faure wrote:
> > >>  No. The next best option is still patching Qt, even if TT doesn't
> > >> give a damn about the patch. That's their problem, not ours, and
> > >> there's no point in complicating our lives by adding a duplicate
> > >> function in kdelibs. Qt-copy/patches is not only for patches TT like,
> > >> it's also for patches they don't like. Why do you think Qt3-based
> > >> qt-copy patches has so many so old patches?
> > >
> > >API additions are a big no-no though.
> >
> > We're talking about making an already-existing static function a lot
> > faster. I think it qualifies.
>
> Ralf said
> "The patch is appended. It adds
> static bool QFileInfo::isAbsolute(const QString &path);
> static bool QFileInfo::isRelative(const QString &path);
> [...]"
>
> That's new API, which can't go into qt-copy only if TT doesn't want it,
> otherwise KDE will never compile with official versions of Qt, that's what
> I meant. But apparently you guys at TT are okay with this patch so this
> isn't a problem, I was only replying to "qt-copy/patches is also for
> patches TT doesn't like": not if they add API.

That's because Ralf designed the patch like that. He didn't have to add new 
API.

Anyways, I'm in the middle of testing the patch. Unfortunately, the QDir unit 
tests we have did not work on my machine, so I needed to fix them in order to 
get a baseline for comparison.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080311/bf17faa7/attachment.sig>