[PATCH] KBookmarks / fd.o desktop-bookmark-spec

[nf2]

nf2 wrote:
> Tobias Koenig wrote:
>> On Fri, Mar 07, 2008 at 10:56:43AM +0100, nf2 wrote:
>>  
>>> Tobias Koenig wrote:
>>>    
>>>> If m_kDirWatch is initialized properly, a 'delete d->m_kDirWatch' is
>>>> enough. Best would be to move it in the dtor of the private class.
>>>>         
>>> d->m_kDirWatch is not always set. I only need it in the 
>>> "external-bookmark-file" mode.
>>>     
>> Yes, but under C++ a 'ptr = 0; delete ptr;' is no problem
>> in opposite to C.
>>
>>
>>   
>
> Ok - i fixed this (And moved it to the dtor of the private class).
>
> Also changed it to use: for ( QDomeElement e = 
> metaDataNode.firstChildElement(); !e.isNull(); e = 
> next.SiblingElement() ) in KBookmark::metaDataItem() as you suggested 
> earlier.
>
> Here is the new patch. May i commit this to trunk?
>
>

Oops - i messed up the dbus notification interfaces in the previous 
patch a bit. This one should look better.

regards,
Norbert





-------------- next part --------------
A non-text attachment was scrubbed...
Name: kbookmark_improvements3.patch
Type: text/x-patch
Size: 19469 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080310/b90e1b6d/attachment.bin>