[PATCH] KBookmarks / fd.o desktop-bookmark-spec

[Tobias Koenig]

On Fri, Mar 07, 2008 at 10:56:43AM +0100, nf2 wrote:
> Tobias Koenig wrote:
Hej,

>> Don't mark a method as 'const' when it changes the internal state of a
>> class!
>>
>>   
>
> Unfortunately this (private) method has to be called from another const 
> method (KBookmarkManager::saveAs()). Changing it to non-const would 
> probably break the API, but i'm not an expert here.
Hmm, too bad...

>> If m_kDirWatch is initialized properly, a 'delete d->m_kDirWatch' is
>> enough. Best would be to move it in the dtor of the private class.
>>   
>
> d->m_kDirWatch is not always set. I only need it in the 
> "external-bookmark-file" mode.
Yes, but under C++ a 'ptr = 0; delete ptr;' is no problem
in opposite to C.

Ciao,
Tobias
-- 
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institution!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080307/886a36ce/attachment.sig>