Fixing i18n + global shortcuts

[Andreas Hartmetz]

Am Dienstag 04 März 2008 16:13:25 schrieb David Faure:
> On Tuesday 04 March 2008, Thiago Macieira wrote:
> > On Tuesday 04 March 2008 14:46:24 Lubos Lunak wrote:
> > >  I don't see any need to store i18n-ed shortcut names in the config or
> > > in the kded module if kcmkeys is changed back to some #include-like
> > > solution for a list of shortcuts that should be configurable there. In
> > > the thread about this about a month ago ('Global shortcuts and i18n') I
> > > don't see any comments from you on this though - what's your position
> > > on that?
> >
> > I'd just like to make a note:
> >
> > kwin is almost unusable right now because of i18n'ed global shortcut
> > names. The shortcuts are assigned to the English version of the names,
> > but kwin acts on the Portuguese translation in my system. I don't know
> > what the issue is or if it's just a config issue.
> >
> > In any case, please make sure that you do not write i18n names to the
> > config files. Ever.
>
Technically localized names will still end up in the config file but only 
informational - the action/shortcuts will be referenced by an untranslated 
name.

> That's what Andreas' patch fixes.
>
Right :)

> Lubos' question is more about: do we want to use the kded module for the
> kcm (and then it needs to know the translated texts of the shortcuts too),
> or do we want to go back to some #include-like solution
> (which I find ugly and unflexible, personally).

There is a good reason to store localized names (as well as untranslated ones, 
see above) in kded: Imagine a message box saying "Your chosen shortcut is 
already taken by action $FOO, do you want to steal it from that action?". 
Such message boxes exist and they need $FOO to be translated [even when the 
application possessing $FOO is not available for comments via DBus]. While we 
have that information anyway we can as well use it for KCMs.
Note that I favored an #include-like solution too before I realized that :}