[PATCH] XMLGUI Crash Fix
faure at kde.org
Mon Mar 3 09:35:29 GMT 2008
On Saturday 01 March 2008, Roman Jarosz wrote:
> This patch fixes crash when applying toolbar changes in Kopete Chat View.
> Kopete Chat View was crashing because ContainerNode for mainToolBar wasn't deleted but
> KToolBar(mainToolBar) container was. So while the menu was regenerated the KXMLGUIBuilder
> found the old ContainerNode but the ContainerNode was pointing to already deleted KToolBar.
This is quite surprising. I assume this didn't happen in KDE3?
I am not aware of core changes in XMLGUI since KDE3 -- except from possible porting errors;
so I am reluctant to see changes in the logic if those changes were not necessary in KDE3 and
I recommend finding the difference with kde3 if there is one (if it works there then it's a porting
bug in kde4, if it also breaks there then ok for fixing the logic).
> So the crash is fixed, but there is still a bug because when the menu is regenerated some default
> actions are missing. For instance the Tools menu in Kopete Chat View which contains history actions is
> missing or the history actions aren't on mainToolBar.
Sounds like missing plugActionList calls in the slot connected to kedittoolbar, if you use plugActionList
already elsewhere; see kedittoolbar documentation.
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel