[PATCH] high CPU load in kded when kdirwatcher falls back to polling

[Allen Winter]

On Sunday 25 May 2008 08:09:11 Till Adam wrote:
> Folks,
>
> on my current OSX Leopard build KDirWatcher seems to want to not use fam,
> although it was found at compile time and thus falls back to polling.
> Unfortunately it doesn't unhook the socket notifier, which keeps firing,
> for some reason, resulting in constant event handler -> singleShotTimer ->
> noop cleanup slot cycles, which burn a lot of CPU. The attached patch
> attempts to address this by making sure the socket notifier is deleted in
> all cases that disable fam. I lack the deeper insight into the code to
> judge whether there's more to it, but it solves the immediate problem for
> me. Kindly review.
>
This patch was never committed.
Should it be?