VLC and MPlayer Phonon backends on KDE repo

[Matthias Kretz]

The patch is a good idea, but can only go into kdesupport/phonon, not 
branches/phonon/4.2. Calling d->_k_mutedChanged from 
setVolumeIcon/setMutedIcon looks wrong. Even if it does the right thing now, 
you probably better should use it there. Also for
+    if (d->icon.isNull()) {
+        d->iconLabel.setVisible(true);
+    }
Did you perhaps forget a "!"? Or you meant "setVisible(false)"? Setting a null 
icon should probably just get ignored. To hide the icon there's already a 
dedicated function.

I'm just wondering since when QStyle has SP_MediaVolume(Muted) and why 
Trolltech didn't patch phonon to use those... Also we should check that 
KStyle implements them correctly. Oh, and the dox are wrong then, it should 
say "Default icon used is QStyle::standardIcon(QStyle::SP_MediaVolume)". Too 
bad SP_MediaTime wasn't added...

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080604/883d6245/attachment.sig>