[PATCH] re-implement void kurlcompletion.cpp|DirectoryListThread::run() with Qt calls

David Faure faure at kde.org
Wed Jun 4 09:20:17 BST 2008


On Saturday 31 May 2008, Michael O'Shea wrote:
> People,
> 
> I submitted a first draft of this a few weeks ago. David Faure made a few
> suggestions which I carried out.
> 
> Here's a new version of the patch.
> 
> Its purpose is to re-implement void DirectoryListThread::run() (found in
> kurlcompletion.cpp) using Qt calls.

Looks OK, but
1) you reverted some getenv->qgetenv changes, please undo that
2) you probably want to comment out the verbose kDebug calls before committing 

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list