[PATCH] logout fadeeffect

[Lubos Lunak]

On Saturday 26 of July 2008, Tobias Koenig wrote:
> On Thu, Jul 24, 2008 at 05:27:03PM +0200, Lubos Lunak wrote:
> > On Thursday 24 of July 2008, Tobias Koenig wrote:
> > > If there are no objections I'd really like to commit it for KDE 4.1.
> >
> >  There are. Fetching data from video memory can be quite slow, and that
> > is why it is done incrementally instead of blocking everything (and that
> > is also the reason why the current effect looks so bad compared to the
> > one from KDE3, regardless of "officially" being better because of the
> > thread and MMX and whatnot).
>
> Since you know the X11 stuff best, do you have an idea why when using
> timers, the second (and further) call to XGetSubImage() returns a black
> image instead of the root window content?

 No. Looks like X problem to me. Is it actually returning black? Is the screen 
correct if you turn off delayed iterations (I mean, completely)?

> Does the ksmserver change the content of the root window in the
> meantime?

 Yes, but that shouldn't matter.

> What is your suggestion how to fix it?

 Does it happen with a different widget style? Does it happen if you change 
logouteffect.cpp to use the other one? Does it work if you disable ARGB usage 
in main.cpp in checkComposite() or use the other way in the 
KApplication-creating if()? Does the logout effect in KDE3 work?

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz