[PATCH] Use KUrl::prettyUrl to display user entered remote URLs in KUrlComboBox

David Faure faure at kde.org
Mon Jul 21 11:00:08 BST 2008


On Friday 18 July 2008, Sebastian Trüg wrote:
> On Friday 18 July 2008 16:00:10 Sebastian Trüg wrote:
> > On Friday 18 July 2008 15:10:24 David Faure wrote:
> > > On Friday 18 July 2008, Sebastian Trüg wrote:
> > > > On Friday 18 July 2008 11:47:53 Andreas Pakulat wrote:
> > > > > On 18.07.08 11:26:06, Sebastian Trüg wrote:
> > > > > > May I apply this patch?
> > > > > > trunk and 4.1?
> > > > >
> > > > > How about adjusting the code a bit more and using KUrl::pathOrUrl()?
> > > > > Would save the else part.
> > > >
> > > > strangly pathOrUrl does not have an option parameter. Maybe that could
> > > > be added for 4.2?
> > >
> > > Oh. No reason this is missing, indeed. Added.
> >
> > ok, updated patch for trunk. May I commit and use the old patch for 4.1?
> >
> > Cheers,
> > Sebastian
> 
> sorry, apparently there is not just one place for this change in the file.
> Updated patch attached.

Looks good and quite shorter indeed.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list