[PATCH] KFileDialog overwrite confirmation

[Thiago Macieira]

Rafael Fernández López wrote:
>Thiago Macieira <thiago at kde.org> wrote:
>> I made that part of techbase less evident because we prefer to use the
>> meta-method mechanism whenever possible (in QObject-derived classes).
>
>I really think this is a really good chance for maintaining code. I
>mean, if we create an enum where all new "fake virtual methods" have
>been added, is just a matter of reviewing each enums of that kind to
>see what needs to be added as virtual for a next "big" KDE version.
>
>It is less evident with meta-method mechanism because everything is a
>bit "mixed".

We had agreed on dropping the virtual_hook requirement for KDE 4 for 
QObject-based classes because there's a replacement. It avoids having to 
add this unused method to our classes and enlarging the virtual table.

Besides, when we do KDE 5, we should look for "### KDE5" comments 
everywhere. A comment of "### KDE 5: make this virtual" is just fine.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080714/c22a9ea2/attachment.sig>