[PATCH] KFileDialog overwrite confirmation

Rafael Fernández López ereslibre at kde.org
Mon Jul 14 03:44:47 BST 2008

> It can't, it would break BC. ;)

Hehe, that's cheating ! I said that on the beginning on this post ;). I meant 
that if that method needs to be virtual (or some of kind of, preserving BC, we 
have some workarounds for it), or not at all.

From what subclasses do on the patch Alessandro provided, it doesn't seem to 
exist this need of that class being virtual (or, as I said, something "like" 
being virtual).

> However I pretty much agree with your idea on making it an enum in general
> for readability.

I think that lots of classes could have some benefit of defining virtual 
hooks... If we take this as a general approach for writing extendable classes, 
it will be trivial to merge them on later big versions of KDE.

> And yes, deliberately bouncing unhandled code to KAbstractFileWidget is
> likely to crash since it is defined as = 0.  But there's nowhere else to go
> to handle it so there's no use in trying to hide the error (and you never
> know when an implementation will later be added.)

I guess it wouldn't compile...

Rafael Fernández López.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080714/7c823345/attachment.sig>

More information about the kde-core-devel mailing list