Suspicous code in KDE 4 trunk r764353

[Lubos Lunak]

On Tuesday 22 of January 2008, Christoph Bartoschek wrote:
> - kdebase/workspace/kwin/clients/plastik/plastikbutton.cpp:203
>
> alpha is not initialized if lines 194 and 198 are not true.

 Hopefully fixed correctly.

> - kdebase/workspace/kwin/clients/b2/b2client.cpp:168
>   kdebase/workspace/kwin/clients/b2/b2client.cpp:170
>
> Highly probably two breaks are missing

 Fixed.

>
> - kdebase/workspace/kwin/effects/thumbnailaside.cpp:146
>
> If it is possible that windows.size() == 0 then height is 0 here.

 Fixed.

> - kdebase/workspace/khotkeys/shared/input.cpp:189
>
> keysym is uninitialized
>
> - kdebase/workspace/khotkeys/shared/input.cpp:217
>
> x_mod is uninitialized

 The whole function actually starts with 'return false;'.

> - kdebase/workspace/kwin/events.cpp:1664
>
> A break is probably missing.

 Yes, although harmless. Fixed.

> - kdebase/workspace/khotkeys/kcontrol/condition_list_widget.cpp:285
>
> If parent2_P is NULL and parent1_P is NULL this method crashes here

 One of them is always not NULL.

>
> - kdebase/workspace/ksplash/ksplashx/scale.cpp:194
>   kdebase/workspace/ksplash/ksplashx/scale.cpp:221
>   kdebase/workspace/ksplash/ksplashx/scale.cpp:248
>
> If d is 0 problems arise later.

 That would mean image with no height/width, not allowed.

>
> - kdebase/workspace/ksplash/ksplashx/qcolor.cpp:503
>
> Lines 505 and 507 use && and not &. This one of the reasons to use &&
> here too.

 Fixed.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz