Patch for KTabBar Close Buttons

Andras Mantia amantia at
Tue Jan 22 08:49:40 GMT 2008

On Tuesday 22 January 2008, Allen Winter wrote:
> On Friday 23 November 2007 18:23:50 csh wrote:
> > Hi everyone,
> >
> > this is my first patch ever. It implements close buttons for tabs.
> > The only thing I couldn't quite figure out is the formula for the
> > icon postion, but besides that it should be fine.
> Was this patch ever committed (with Aaron's suggested changes) ?

If I'd know about this patch... :( 
No, it was not committed, and I did the same thing (with different 
code), posted here, and committed.
Sorry Christoph. If anyone wants to check which one is better, I don't 
mind dropping my solution. This code looks better thought (I just 
adapted the old one to KDE4, without refactoring), but the 
KTabBar::findIconGeometry(const int index) probably fails in many cases 
(active tabs, different styles used).


Quanta Plus developer -
K Desktop Environment -
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list