Suspicous code in KDE 4 trunk r764353

Allen Winter winter at kde.org
Tue Jan 22 03:44:09 GMT 2008


I'll backport these fixes tomorrow.
Christoph, thanks for this report.  I hope you can send them regularly.
-Allen

>- kdepimlibs/kcal/kresult.cpp:105
>
> A very nice way to directly crash. There seems to be no coverage of
> this method.
>
fixed

> - In the generated file
>   build/kdepimlibs/kcal/libical/src/libical/icalrestriction.c:307
>
> stat is of enum icalproperty_status
> The return value of icalproperty_get_action(prop) is of enum
> icalproperty_action.
>
fixed
>
> - In the generated file
>   build/kdepimlibs/kcal/libical/src/libical/icalrestriction.c:312
>
> stat is of enum icalproperty_status
> ICAL_ACTION_EMAIL is of enum icalproperty_action
>
fixed
>
> - In the generated file
>   build/kdepimlibs/kcal/libical/icalderivedproperty.c:2393
>
> pkind is of enum icalproperty_kind
> ICAL_NO_VALUE is of enum icalvalue_kind
>
fixed
>
> - kdepimlibs/kcal/libical/src/libical/sspm.c:437
>
> Calling strdup with a NULL pointer (line 435) might be a bad idea.
>
fixed
>
> - kdepimlibs/kcal/libical/src/libical/sspm.c:454
>   kdepimlibs/kcal/libical/src/libical/sspm.c:494
>
> major_content_type_map[i].type has type 'enum sspm_major_type'
> SSPM_UNKNOWN_MINOR_TYPE has type 'enum sspm_minor_type'
>
fixed
>
> - kdepimlibs/kcal/libical/src/libical/sspm.c:1605
>
> If header is NULL buf.buffer is uninitialized.
>
fixed

>
>
> - kdepimlibs/kcal/scheduler.cpp:439
>
> Line 434 indicates that ev might be NULL here.
>
fixed








More information about the kde-core-devel mailing list