[PATCH] Fix crash when using kdiroperator

Rafael Fernández López ereslibre at kde.org
Mon Jan 21 23:19:41 GMT 2008


Hi,

When talking about a crash it would be nice to tell the steps to reproduce:

1. Open the open/save dialog (with previsualizations disabled by default)
2. Click wherever on the view (on the blank part, not on an item) => crash

> The attached patch fix a bug that was causing a crash when using
> kdiroperator.

BTW, it is my fault. I committed this code and forgot about that check, 
thanks.

> Ok to commit?

Yes please, but remember that this is only committable on trunk. DO NOT 
backport.

> Btw, what is the commit policy, a commit like this that only fixes a
> crash and don't
> break any code could be committed directly?

Better to ask first, but this is a big yes.


Bye and thanks again,
Rafael Fernández López

GPG Fingerprint: B9F4 4730 43F8 FFDD CC5E BA8E 724E 406E 3F01 D070
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080122/083425bb/attachment.sig>


More information about the kde-core-devel mailing list