[PATCH] Rename dialog is too big (or too narrow)

Andras Mantia amantia at kde.org
Mon Jan 21 10:59:55 GMT 2008


Hi,

 if you copy an audio file over somewhere else, where it already exists, 
the rename dialog will show you the full path to the source. If this 
path is long, your dialog will not fit onto the screen. Presenting the 
path is too much IMO, as you are interested only in the name of the 
file, not the path from where it comes (even the message says 
"A similar file named '%1' already exists" ). 

In case when no rename dialog is shown, KSqueezedTextLabel is used in 
order to fix the problem. The problem is here again that it shows the 
path to the file, but talks about the file name. It should show only the 
file name. In case of the second message where it shows what is the 
source file, I think it's good to present the full path.

Patch1 fixed the second case, patch2 fixes the first.

There are still problems remaining:
1) if the file name is too long, it might again grow the dialogs, as I 
changed to QLabel in the second case (audio plugin used QLabel from the 
start)
2) KSqueezedTextLabel trims too much from the url. :( Eg. from a file 
called "Diplomacy.pdf" it shows only '...y.PDF" if I pass the file name, 
and for /data/Documents/Diplomacy/Diplomacy.pdf" shows only 
"/...lomacy/Diplomacy.pdf", which is rather useless (especially that the 
path is not that long). I think this should be fixed inside 
KSqueezedTextLabel.

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: renamedialog-1.patch
Type: text/x-patch
Size: 2160 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080121/7aae2b28/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: renamedialog-2.patch
Type: text/x-patch
Size: 511 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080121/7aae2b28/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080121/7aae2b28/attachment.sig>


More information about the kde-core-devel mailing list