[PATCH] Don't loose shortcuts when closing global shortcut kcm

[Aurélien Gâteau]

Lubos Lunak wrote:

> On ne 20. ledna 2008, Aurélien Gâteau wrote:
>> An alternative solution could be adding a flag to KAction to instruct it
>> not to remove the global shortcut, but it would clutter the API for a
>> very marginal use IMHO.
> ...
>> Then in the KCM we would create a FakeAction class, inheriting from
>> KAction and reimplementing removeShortcuts() to be an empty method. Don't
>> know which one is the best.
> 
>  Wouldn't work - virtuals don't work as virtuals in ctors/dtors.

Oups, I shouldn't send email too late in the evening :-).
 
> On so 19. ledna 2008, Kevin Ottens wrote:
>> Le samedi 19 janvier 2008, Aurélien Gâteau a écrit :
>> For this part I'm just checking because it looks like it'll clash with a
>> fix I'm working on. I'd prefer avoiding stepping on your toes. ;-)
> 
> Hmm, you too :) ?

Are you all by chances working on the "KWin shortcuts do not appear in the
shortcut kcm" bug? I have it almost fixed. I just need to work a bit more
on the way shortcuts are loaded and saved.

Aurélien