[PATCH] KEditListBox::setCustomEditor

[David Faure]

On Friday 18 January 2008, Sebastian Trüg wrote:
> On Friday 18 January 2008 18:10:22 Sebastian Trüg wrote:
> > On Friday 18 January 2008 17:51:30 Leo Savernik wrote:
> > > Am Freitag, 18. Januar 2008 schrieb Sebastian Trüg:
> > > > > >  * Whenever the selection changes the lineedit gets the focus. This
> > > > > > is very convenient as it saves one click and there is no real use
> > > > > > for the keyboard focus in the listview.
> > > > >
> > > > > Are you sure? What about users without a mouse? Can they still use
> > > > > Key_Up/Key_Down in the listview?
> > > >
> > > > Hm, users without a mouse can change the selection by tabbing into the
> > > > listview and then changing it. But they have to tab into it for each
> > > > change, i.e. Key_Tab->Key_Down->Key_Tab->Key_Down. While this might not
> > > > be very nice IMHO most users will handle KEditListBox with a mouse and
> > > > then the focus feature is very very convenient.
> > >
> > > You effectively made the edit line a focus proxy of the listview.
> > > Therefore, I'd consider it sane to dispatch keypresses targeted at but
> > > not related to the edit line directly to the listview. This would make
> > > Up/Down do the "right thing" with the edit line having focus.
> >
> > good idea. Done. New patch attached including fixed tab order and icons on
> > buttons.

Good idea indeed, patch looks good.

> Hm, answering to my own mail. I think I broke BC with the introduction of 
> eventFilter, right?

No you didn't. But this comment gave you the right to re-read
http://techbase.kde.org/index.php?title=Policies/Binary_Compatibility_Issues_With_C%2B%2B
:-)

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).