[PATCH] KEditListBox::setCustomEditor

[Sebastian Trüg]

On Friday 18 January 2008 17:51:30 Leo Savernik wrote:
> Am Freitag, 18. Januar 2008 schrieb Sebastian Trüg:
> > > >  * Whenever the selection changes the lineedit gets the focus. This
> > > > is very convenient as it saves one click and there is no real use for
> > > > the keyboard focus in the listview.
> > >
> > > Are you sure? What about users without a mouse? Can they still use
> > > Key_Up/Key_Down in the listview?
> >
> > Hm, users without a mouse can change the selection by tabbing into the
> > listview and then changing it. But they have to tab into it for each
> > change, i.e. Key_Tab->Key_Down->Key_Tab->Key_Down. While this might not
> > be very nice IMHO most users will handle KEditListBox with a mouse and
> > then the focus feature is very very convenient.
>
> You effectively made the edit line a focus proxy of the listview.
> Therefore, I'd consider it sane to dispatch keypresses targeted at but not
> related to the edit line directly to the listview. This would make Up/Down
> do the "right thing" with the edit line having focus.

good idea. Done. New patch attached including fixed tab order and icons on 
buttons.

Cheers,
Sebastian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: keditlistbox-custom-editor.diff
Type: text/x-diff
Size: 26532 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080118/6a58c7e4/attachment.diff>