[PATCH] Drag And Drop bug in K3ListView

Roman Jarosz R.Jarosz at sh.cvut.cz
Tue Jan 15 16:38:18 GMT 2008


On Tue, 08 Jan 2008 20:45:13 +0100, Allen Winter <winter at kde.org> wrote:

> On Friday 04 January 2008 14:47:01 David Faure wrote:
>> On Tuesday 01 January 2008, Roman Jarosz wrote:
>> > Hi
>> >
>> > I've found a bug in drag&drop code in K3ListView.
>> >
>> > The problem is visible in Kopete. If we start a drag, then
>> > K3ListView::contentsDragEnterEvent is called and a drag enter event is
>> > only accepted if acceptDrag return true. But in Kopete, when we start the
>> > drag the acceptDrag always returns false, because we can't drop to the
>> > same group in contact list and since the drag enter event wasn't accepted
>> > in contentsDragEnterEvent, the contentsDragMoveEvent is never emitted and
>> > we cannot control the drag.
>> >
>> > Below is a patch that fixes this bug. I've looked at Q3ListView, Q3Table
>> > and Q3IconView code and it's always accepted there.
>> >
>> > Can I commit this fix
>>
>> Yep, please do.
>
> Was this patch ever committed?

Sorry forgot about it, it's commited.







More information about the kde-core-devel mailing list