[PATCH] Add back the close buttons to KTabBar/KTabWidget

Andras Mantia amantia at kde.org
Mon Jan 14 22:52:41 GMT 2008


 attached is a patch that adds back the functionality described in the 
subject. The API was already there, but the code was commented out. :(
Finding the place where the icon should appear on a tab is black magic. 
I did the best I could to have it work with all styles I have installed, 
but still some issues remained and I'm unsure how can this be fixed on 
this level (perhaps the problematic styles could be adapted):
1) Oxygen: for the active tab, the close icon appears one pixel above 
from where it should
2) Cleanlooks: the icon is bigger then expected, but this is a general 
issue with this style (see the icons on the pushbuttons)
3) CDE: the icon are shifted left-bottom, both for active and inactive 

All the others are fine, except that there is not much visual feedback 
when the mouse if over the close icon. 
Although this sounds bad, it wasn't better in KDE3 either. The position 
and the look of the icons depend on the styles there as well.
I think if in the oxygen the icon for active tabs could be drew one 
pixel lower, this would be almost perfect.

Anyway, more testing is probably required, I might have missed 

Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ktabbar.patch
Type: text/x-patch
Size: 8326 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080115/0e57fd66/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080115/0e57fd66/attachment.sig>

More information about the kde-core-devel mailing list