[PATCH] add setAutoDelete/isAutoDelete to KJob

Kevin Ottens ervin at kde.org
Tue Jan 8 18:20:59 GMT 2008


Le lundi 7 janvier 2008, David Faure a écrit :
> On Saturday 05 January 2008, Andreas Pakulat wrote:
> > +
> > +    /**
> > +     * Returns wether this job automatically deletes itself once
> > +     * the job is finished.
> > +     *
> > +     * @return wether the job is deleted automatically after
> > +     * finishing.
> > +     */
> > +    bool isAutoDelete() const;
>
> s/wether/whether/. Looks good otherwise :-)

I also has a small violation on the file style, you should add a space before 
the opening parenthesis on ifs.
Otherwise looks good, please commit after the proposed changes.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080108/e52931e9/attachment.sig>


More information about the kde-core-devel mailing list