[PATCH for 4.0] make FindFreetype.cmake compatible with FindFreetype from cmake
neundorf at kde.org
Fri Jan 4 13:25:58 GMT 2008
On Friday 04 January 2008, Matt Rogers wrote:
> On Jan 4, 2008, at 6:44 AM, Alexander Neundorf wrote:
> > On Friday 04 January 2008, Alexander Neundorf wrote:
> >> Hi,
> >> the attached patch makes the "interface" of FindFreetype.cmake
> >> compatible
> >> with the interface of FindFreetype.cmake in cmake cvs (commit to
> >> cmake cvs
> >> will follow) by adding the variable FREETYPE_INCLUDE_DIRS, which
> >> is set
> >> equal to FREETYPE_INCLUDE_DIR.
> >> I'd like to have that in 4.0 because this way KDE 4.0.x developers
> >> can use
> >> the "API" of FindFreetype.cmake as it will be in cmake's version.
> >> Having different interfaces to the same cmake module sucks,
> >> because it
> >> means that
> >> * once we require CMake 2.6 (maybe KDE 4.2) the FindFreetype
> >> module will
> >> only provide FREETYPE_INCLUDE_DIRS, not FREETYPE_INCLUDE_DIR, so
> >> at this
> >> point in time it would be a source incompatible change. Having
> >> _DIRS now in
> >> svn means everybody should use the _DIRS variable already in KDE
> >> 4.0 and
> >> later on it will just work.
> >> * developers have to use them differently whether they are working
> >> in KDE
> >> or outside KDE
> >> Ok to commit ?
> > So no objections ?
> > Alex
> This is not a showstopper, so I object. It should wait until 4.0.1 IMO.
It adds a new variable, which isn't used anywhere right now, so it can't break
anything, it just adds one line:
The new variable follows the style guide for cmake modules and makes the
modules from kde and cmake compatible.
Otherwise we'll release KDE 4.0.0 (and KDE 4.x.y) with a cmake module which is
incompatible to the official one.
I'm thinking mainly 3rd party developers who will use that module and then
will rely on the fact that FREETYPE_INCLUDE_DIR is the variable to use (and
will have to be for KDE 4.x.y), as opposed to FREETYPE_INCLUDE_DIRS which you
have to use when using the module from cmake. This will be *very* confusing.
> Why do we have a different version of FindFreetype.cmake anyways?
Because a different one was added to cmake cvs two weeks ago (not by me).
More information about the kde-core-devel