Making the rating painter class public
Sebastian Trüg
strueg at mandriva.com
Tue Feb 26 11:29:33 GMT 2008
On Monday 25 February 2008 23:12:00 Frank Osterfeld wrote:
> On Monday 25 February 2008, Sebastian Trüg wrote:
> > void draw( QPainter* painter, const QRect& rect, int rating, int
>
> hoverRating = -1 );
>
> I don't get what hoverRating means here from reading the header, so
> documentation wouldn't hurt.
Will do. Stay tuned for update.
> > /**
> > * Calculate the rating value from mouse position pos.
> > *
> > * \return The rating corresponding to pos or -1 if pos is
> > * outside of the configured rect.
> > */
> > int fromPosition( const QRect& rect, const QPoint& pos );
>
> That should be const I think - (and isn't int ratingFromPosition() const
> more clear? This is a RatingPainter, not a Rating after all).
Agreed.
More information about the kde-core-devel
mailing list