[PATCH] KConfig: Rewrite globals only if modified
faure at kde.org
Mon Feb 25 22:29:56 GMT 2008
On Monday 25 February 2008, Oswald Buddenhagen wrote:
> On Mon, Feb 25, 2008 at 11:02:23PM +0100, David Faure wrote:
> > I guess that means "testing that the global config isn't rewritten
> > when not necessary, by comparing its timestamp from before and after
> > the write operation". That's the best way to ensure it won't ever get
> > broken again, by future changes.
> a signature i used quite a time ago seems relevant to that statement:
> nothing is fool-proof to a sufficiently talented fool.
> or we could just use good ol' murphy's law.
> in that case it means that if you introduce that regression test,
> somebody will surely introduce a "timestamp preserving mode" which will
> be accidentally entered exactly at the point when this regtest is
> executed, just in time to cover up the breakage introduced one commit
Are you making fun of me or being the devil's advocate, here? I don't see your point.
Sure, nothing is 100%, but no test is surely worse than a test that only detects 99% of possible breakages.
PS: to be clear, I'm not -requiring- that a unit test be written, of course, I was only suggesting it, if it makes
sense for the fix at hand. Unit tests improve my trust of the correct behavior of a kdelibs class :)
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel