[PATCH] KConfig: Rewrite globals only if modified
faure at kde.org
Mon Feb 25 22:02:23 GMT 2008
On Monday 25 February 2008, Chusslove Illich wrote:
> > [: David Faure :]
> > Any chance for a unit test? :-P
> Cannot reconcile the brevity with my view of reality :)
> That is, what about the already present unit tests for KConfig? As it is,
> they do sync configs and then read and compare stuff.
Well, this only means that you didn't introduce regressions; but I was wondering
if it was possible to actively test for what the patch is fixing - I guess that means
"testing that the global config isn't rewritten when not necessary, by comparing
its timestamp from before and after the write operation". That's the best way to
ensure it won't ever get broken again, by future changes.
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel