[PATCH] Solid circular deletion

Kevin Ottens ervin at kde.org
Tue Feb 19 07:27:46 GMT 2008

Le Tuesday 19 February 2008, Alex Merry a écrit :
> On Tuesday 19 February 2008 01:21:24 Alex Merry wrote:
> > The attached patch seems to fix it, but I'm not sure if it's really the
> > correc t fix - can someone who knows about the code (or using
> > QExplicitlySharedPointe r as a self reference) check it?  It may
> > introduce memory leaks.
> Actually, I'm pretty certain that's not the correct fix.  I've discovered
> that the patch causes crashes when quitting any application that uses
> Solid.

I strongly advise you to write a unit test that show this behavior. And then 
we can work on a proper fix. I have unit tests for device unplugging already, 
and they don't show up this problem, so they probably need to be completed to 
catch your case.

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080219/56de6e3d/attachment.sig>

More information about the kde-core-devel mailing list