[PATCH] Previews in KDirOperator

[Jon de Andrés Frias]

Sorry!! This weekend i've not read the mailing list...

El Friday 15 February 2008 21:43:48 Peter Penz escribió:
> On Friday, 15. February 2008 21:10:07 David Faure wrote:
> > On Friday 15 February 2008, Peter Penz wrote:
> > > I did the porting of KDirOperator from KDE 3 to KDE 4, but I don't see
> > > myself as maintainer of this class -> it would be great if somebody
> > > else could have a look on this changes too.
> >
> > Well nobody else is maintaining it (the author has been inactive for a
> > long time), so your opinion counts more than anyone else's :-)
>
> Well, I did not port the preview-capability from KDE3 because of limited
> time, so I think we should bring it back to our users... :-)
>
> > The only thing I'm wondering is: shouldn't "previews enabled" be a
> > setting of the icon/detail views, like in dolphin, instead of being a
> > third view mode?
>
> Good question...
>
> The icons/details-view inside the file-dialog use an icon size of 16x16
> pixels, where a "enable preview" does not make much sense until we provide
> also zoom in/zoom out actions.
>
> Instead of using zoom in/zoom out actions maybe an idea might be to
> automatically increase the item size as soon as the preview is enabled ->
> we would still have 2 view modes (icons/details) and only one
> preview-toggle button.
>
> @Jon: what do you think about not adding a third view mode but a
> preview-toggle like in Dolphin + automatical resizing of the item size?

I think it's a good idea to provide the preview mode in the views already 
exist in kdiroperator, that's really cool. As you say, Peter, would be 
necessary to increase the icon size when this mode is enabled. Guys, i can 
work on it :-).

About this...do you think that the Simple and Detailed views are enough? 
Shouldn't KDirOperator have an icon mode view?  If you think that this is not 
useful there is no problem, but at this time i have, with the patch i sent, 
an icon view with previews. I can separate the two features, toggle the 
preview mode and add a new view mode.
>
> Peter

Jon


-- 
Jon de Andrés Frías