KColorCells fails on resizing rows/columns

[Percy Camilo Triveño Aucahuasi]

>Patch is starting to look good.
Thanks ; )

>The kdelibs coding style is more "brace on the same line" than "brace on
its own line", >though, so

In fact the original file doesn't had a good coding style ... any way you're
right, I had to use "astyle" and now the patch contain the changes to
KColorCells plus a coding style acoring to kdelib policies ;).

Thanks for all the help and tips ; ).

The commit is done now.

Greetings

2008/2/13, David Faure <faure at kde.org>:
>
> On Tuesday 12 February 2008, you wrote:
> > >Good. Can we see the new patch? ;-)
> >
> > Hello David, sorry I forgot attach the new one : ).
> >
> > Also I removed the the member "acceptDrags" of KColorCellsPrivate,
> becouse
> > QAbstractItemView has a property called "dragEnabled", so the method
> > KColorCells::setAcceptDrags does a call to
> > QAbstractItemView::setDragEnabled. I don't remove the public method
> > KColorCells::setAcceptDrags but I think that in the future this method
> has
> > to removed.
>
> Patch is starting to look good.
>
> The kdelibs coding style is more "brace on the same line" than "brace on
> its own line", though, so
>
> -    if ( tableItem == 0 ) {
> +    if ( tableItem == 0 )
> +               {
>
> should be reverted.
>
> +                                       QTableWidgetItem * tableItem =
> itemAt(event->pos());
> using tabs? Please make it 4 spaces.
>
> Once the coding style is unified, feel free to commit.
>
> --
> David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org
> ).
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080213/71578cbf/attachment.htm>