KColorCells fails on resizing rows/columns

Percy Camilo Triveño Aucahuasi orgyforever at gmail.com
Tue Feb 12 19:41:22 GMT 2008


>Oh, your patch is the wrong way round.

Sorry, my mistake.

>Please submit a patch the other way round, and clean up the code (you can
remove the comments like
>"NOTE: Now this class are using QTableWidgetItem to stored and retrieve the
data( color )", this is obvious from the code,
>you can also remove all the "old" code that you commented out).

Done ; )

Greetings

2008/2/12, David Faure <faure at kde.org>:
>
> On Monday 11 February 2008, Percy Camilo Triveño Aucahuasi wrote:
> > ; ) ... ok , I also fix a bug ... when you drop a color in a void cell
> (cell
> > without color) the application crasshed
>
> Oh, your patch is the wrong way round.
>
> -    //QColor *colors; // WARNING NOT NESCESARY ... erase this member,
> dont alow dynamic alloc..
> +    QColor *colors;
>
> I guess you commented it out, since it's not commented out in the svn
> version.
>
> Please submit a patch the other way round, and clean up the code (you can
> remove the comments like
> "NOTE: Now this class are using QTableWidgetItem to stored and retrieve
> the data( color )", this is obvious from the code,
> you can also remove all the "old" code that you commented out).
>
> --
> David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org
> ).
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080212/4fac5133/attachment.htm>


More information about the kde-core-devel mailing list