[PATCH] fixing SSE detection in solid

Kevin Ottens ervin at kde.org
Sun Feb 10 17:36:07 GMT 2008

Le Wednesday 06 February 2008, Tobias Koenig a écrit :
> I assume the bit calculation was off by one half octet, as by using the
> applyed patch seems to work.
> According to the specs, MMX is at bit 23, SSE at bit 25 and SSE2 at bit 26
> 0000 0110 1000 0000 0000 0000 0000 0000 <- msb
> So the bitmask 0x06800000 should cover the SSE/2 and MMX bit and
> 0x02000000 checks for SSE and 0x04000000 for SSE2.
> In the original code 0x00E00000 was used to cover the SSE/2 and MMX bits
> (happens when shifted right by 2) and 0x00200000 for SSE and 0x00400000
> for SSE2 (one '0' too much).

I can't really comment on the bitmasks themselves, but apart from this the 
patch looks good. Once you're sure about the mask used you can commit it.

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080210/6531d626/attachment.sig>

More information about the kde-core-devel mailing list