Toolbars are behaving strangely

[Rafael Fernández López]

Hi all,

I plan to commit the attached patch on Monday 11 if no objections presented 
till that day.

Fixes 2 problems:

1) Open Konqueror. Right button on main toolbar. Text Alignment. Text under 
icons. Reopen Konqueror. That setting is lost.

This is a bug due to KToolbar when xmlgui provides a buttonstyle 
(konq-webbrowsing.rc). At some point the defaults that xmlgui provides are 
overriden with the global settings, and the settings that were going to be 
saved for that toolbar are restored, meaning that when you restart konqueror 
what is actually set is the xmlgui default preference: only icons.

2) Open a KDE app with toolbars with the "Text under icons" chosen. When you 
select the "Only icons" your buttons are bigger than they should. Just 
playing around as for instance starting the app with "Only icons" and then 
setting "Only text" will end up on unreadable strings because of a lack of 
space. Those problems are fixed when you force the toolbar to be updated => 
dragging the toolbar or similar actions.

The attached patch fixes those 2 problems.


Bye,
Rafael Fernández López

GPG Fingerprint: B9F4 4730 43F8 FFDD CC5E BA8E 724E 406E 3F01 D070
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ktoolbar.diff
Type: text/x-diff
Size: 1926 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080207/106dc266/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080207/106dc266/attachment.sig>