A patchset for KSSL's error messages

Richard Hartmann richih.mailinglist at gmail.com
Fri Feb 1 18:09:57 GMT 2008


On Feb 1, 2008 6:00 PM, David Faure <faure at kde.org> wrote:

> Can you rework the enum change in a way that preserves the current values untouched,
> and adds all the new values after them?

I hope this patchset solves the problems you mentioned.The error
messages for SignatureFailed and Expired are, unfortunately,
beyond ugly. On the plus side, no user should ever see them as
any application using them directly is highly unlikely.


Richard

PS: You might want to switch your patch viewer of choice to ignore
whitespace changes as I changed quite a bit of the formatting to
be consistent with what I perceived to be the accepted standard.
I left kjavaappletserver.cpp's formatting alone as it uses tabs in
exactly four lines. If you want, I will happily change that file over
to tabs, as well

PPS: VIM's :set list is great ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ksslcertificate.h.patch
Type: text/x-diff
Size: 2940 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080201/b9f1eb60/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ksslcertificate.cpp.patch
Type: text/x-diff
Size: 32593 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080201/b9f1eb60/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kjavaappletserver.cpp.patch
Type: text/x-diff
Size: 6569 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080201/b9f1eb60/attachment-0002.patch>


More information about the kde-core-devel mailing list