[PATCH] khtml/svg/SVGElement.cpp, [PATCH] kjs/lookup.h

Maksim Orlovich mo85 at cornell.edu
Sun Dec 28 02:26:40 GMT 2008


> The attached patch disambiguates a ?: operator where gcc promotes a 0 to a
> pointer and treats it as a RefPtr, while SS12 doesn't find that conversion
> path. Here I think using RefPtr() is clearer style, as well.

Please go ahead with this. The KJS patch looks good, too, but please add
back the comment about this being a gcc-4.1 workaround.

As for the rest, I'd rather fix them properly --- I am w/o SVN access for
a bit, but should have it back in a week or so.

P.S. For khtml and kjs stuff, may I suggest using kfm-devel?

Thanks,
Maks







More information about the kde-core-devel mailing list