[PATCH] sendbugmail explicit linking?

Adriaan de Groot groot at kde.org
Sat Dec 27 09:46:45 GMT 2008

I've got this patch lying around; sendbugmail makes explicit use of QtNetwork, 
but relies on kdeui pulling that library in. The linker flags we use on 
Solaris force us to list every library that is used, so that's why I add in 
QtNetwork explicitly again (probably should use one of the variables defined 
by FindQt, but you get the idea). The reason I'm asking at all is that I 
thought that we needed to list all the libs used *anyway* now with the new 
CMake reduced link interface? If so, why isn't this being caught elsewhere?

--- kio/misc/ksendbugmail/CMakeLists.txt        (revision 901981)
+++ kio/misc/ksendbugmail/CMakeLists.txt        (working copy)
@@ -7,7 +7,7 @@

 kde4_add_executable(ksendbugmail NOGUI ${ksendbugmail_SRCS})

-target_link_libraries(ksendbugmail  ${KDE4_KDEUI_LIBS})
+target_link_libraries(ksendbugmail  ${KDE4_KDEUI_LIBS} QtNetwork)

 set_target_properties(ksendbugmail PROPERTIES COMPILE_FLAGS -DKIO_EXPORT=)

More information about the kde-core-devel mailing list