[PATCH] khtml/svg/ AtomicString& returns

Adriaan de Groot groot at kde.org
Sat Dec 27 09:29:51 GMT 2008

The move from DOMString to AtomicString in KHTML hasn't gone entirely 
smoothly; there's some code that is no longer intended to be called, but it's 
still there and needs to return values. You can't return "" as an 
AtomicString&, and returning references is sometime tricky anyway.

The attached patch does the wrong thing consistently. It leaks 
(K_GLOBAL_STATIC?), instead of returning (wrongly typed) references to 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SVG.diff
Type: text/x-patch
Size: 2365 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081227/78583cec/attachment.bin>

More information about the kde-core-devel mailing list