should KSaveFile::simpleBackupFile overwrite old backups?
winter at kde.org
Wed Dec 24 14:14:07 GMT 2008
On Wednesday 24 December 2008 5:49:22 am Thiago Macieira wrote:
> Robby Stephenson wrote:
> >On Tuesday 23 December 2008, you wrote:
> >> On Tuesday 23 December 2008 10:33:58 am Robby Stephenson wrote:
> >> > What I've run into is that QFile::copy returns false if the file
> >> > exists. So while I would have expected repeated calls to
> >> > simpleBackupFile() to repeatedly copy the existing file to the
> >> > backup, it actually fails if the backup already exists. Am I reading
> >> > that right?
> >> I don't think this should be the intended behavior.
> >> I think repeated simpleBackupFile() should just work, without having
> >> to call QFile::remove() in between.
> >Thanks. Bug 178640 filed.
> Can you just prepare a patch that does the necessary QFile::remove in the
> simpleBackupFile function?
Robby provided a patch and i committed it.
178640 is fixed now.
More information about the kde-core-devel