[PATCH] fix KDialog to use platform native layout spacing and margins

Allen Winter winter at kde.org
Fri Dec 19 14:47:56 GMT 2008

On Saturday 29 November 2008 2:21:14 pm Christoph Feck wrote:
> Hello,
> this is my first post to this list, so please be gentle with my mistakes :)
Was the final patch in this thread committed?

> I noticed that KDialog uses its own hard coded sizes for spacing and
> margins, which I consider bad, because Qt styles can compute layouts
> depending on widget types and pairs, so even a configurable value would be
> wrong.
> This patch should "move" those fixed values to KStyle, meaning any style
> automatically inherits the KDE defaults (should they ever change).
> Additionally, KDialog no longer sets these attributes on it's TopLayout, so
> that it can respect the style's layoutSpacingImplementation() method, which
> results in better platform native appearance e.g. on QMacStyle.
> I already posted this to kde.bugs.org as bug #176473, since I was not
> subscribed to this list before, and am looking for someone who could review
> this patch. But I am adding it here, too, as I do not know if you prefer it
> here.
> Thanks,
> Christoph Feck (kdepepo on #kde-devel)

More information about the kde-core-devel mailing list